fix: handle FDWatcher exception on closed sockets #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StefanKarpinski or @KristofferC eyes on this would be much appreciated. |
|
I don't really know anything about this code. But it has a merge conflict that needs to be fixed so CI can run. |
Adding checks to handle exception thrown while constructing FDWatcher if the socket handle is closed. Also checking the curl return code while adding handle to multi, and not proceeding if that failed. Should fix JuliaLang#253
tanmaykm
force-pushed
the
tan/fix_socket_callback
branch
from
5643a85 to
2115a86
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
- Coverage 89.70% 89.36% -0.35%
==========================================
Files 5 5
Lines 583 630 +47
==========================================
+ Hits 523 563 +40
- Misses 60 67 +7 ☔ View full report in Codecov by Sentry. |
|
I have updated the branch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding checks to handle exception thrown while constructing FDWatcher if the socket handle is closed. Also checking the curl return code while adding handle to multi, and not proceeding if that failed.
Should fix #253