Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI actions versions #252

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

JamesWrigley
Copy link
Contributor

I noticed that some of the CI actions versions were out of date so I took the liberty of updating them.

I think an admin will need to add a CODECOV_TOKEN secret to the repo before this is merged because tokenless uploading is unsupported now: https://github.com/codecov/codecov-action?tab=readme-ov-file#breaking-changes
That might be why the last commit shown on codecov is from 5 months ago: https://app.codecov.io/gh/JuliaLang/Downloads.jl/commits

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.68%. Comparing base (05f9ec2) to head (eae0eef).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   89.70%   90.68%   +0.97%     
==========================================
  Files           5        5              
  Lines         583      612      +29     
==========================================
+ Hits          523      555      +32     
+ Misses         60       57       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StefanKarpinski
Copy link
Member

@DilumAluthge or @staticfloat, either of you know where to get a CODECOV_TOKEN secret?

@giordano
Copy link
Contributor

giordano commented Oct 7, 2024

https://app.codecov.io/account/gh/JuliaLang/org-upload-token (need to be an admin of the github org). It can be added to org secrets, so that not every repo needs to add it.

@DilumAluthge
Copy link
Member

I can do this later tonight. I'll do it organization-wide.

@DilumAluthge
Copy link
Member

I now remember that I already did this organization-wide for the JuliaLang repo. We should be good to go. Let me re-trigger CI, and then let's check the logs and make sure that the Codecov upload worked.

@giordano
Copy link
Contributor

giordano commented Oct 7, 2024

Since this PR was opened from a fork, the token is irrelevant, since codecov will always do the tokenless upload

with:
file: lcov.info
fail_ci_if_error: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably just me, but I hate failing CI when codecov is broken.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we set this to false if the PR is from a fork, and true if the PR is not from a fork?

The Codecov upload should be pretty reliable on non-fork PRs, because we use our CODECOV_TOKEN secret in that case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not about the token being available, but in my experience codecov sometimes fails randomly because it isn't particularly reliable (and they have a track record as a company of mess-ups, remember https://about.codecov.io/security-update/?)

@DilumAluthge
Copy link
Member

🤦

You are correct.

@DilumAluthge
Copy link
Member

So we can just merge this as soon as CI is done.

@DilumAluthge DilumAluthge merged commit 78e7c7c into JuliaLang:master Oct 7, 2024
20 checks passed
@DilumAluthge
Copy link
Member

The CODECOV_TOKEN and the Codecov upload are working correctly, see e.g. https://github.com/JuliaLang/Downloads.jl/actions/runs/11225825897/job/31205214404

@JamesWrigley JamesWrigley deleted the ci-actions branch October 8, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants