Allow specifying the username #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 90.26% 89.81% -0.46%
==========================================
Files 5 5
Lines 575 579 +4
==========================================
+ Hits 519 520 +1
- Misses 56 59 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
It seems the single CI failure is caused by a lack of test coverage of this diff. I wasn't really sure how to test this, though. Does anyone have tips on that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libcurl's SSH key-based and agent-based authentication methods don't work unless the username is set, either by including it in the URL or by setting
CURLOPT_USERNAME. This PR adds ausernamekeyword to thedownloadandrequestfunctions to allow the user to optionally specify a username.Related to this discourse discussion: https://discourse.julialang.org/t/privately-hosting-binarybuilder-products-with-authentication/88409