-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for argument names, keyword arguments and argument default values #399
Conversation
Needs again corresponding changes in libcxxwrap-julia: JuliaInterop/libcxxwrap-julia#142 Is based on the docstring merge request #396 ... |
Thanks for this, I would like to integrate this together with the docstring support in the next release, so that way we only have one breaking change. |
If this is ready for you I can merge this into the |
Ready from my side - only remaining thing is to further update the README (breaking changes and examples for keyword/default arguments) |
It seems that sometimes an extra
See log at e.g. https://github.com/JuliaInterop/libcxxwrap-julia/actions/runs/7514928755/job/20458329641#step:4:495 And there is also a precompile error on Julia 1.6: |
I tried to fix both problems, can you triger the checks @barche ? |
Thanks, I added your last commit to the |
The changes are merged into main now, it should be possible to test by doing |
Inspired by pybind11, this allows to write:
Which translates roughly to:
Also supports docstrings (just a
const char*
argument) and additional arguments of some variants of method (calling convention) have extra enum types (to allow parsing arbitrary arguments).Example: