convert: add new RefArray type signature #390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be needed for julia nightly, otherwise the CxxWrap tests error with:
(from https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2023-10/24/CxxWrap.primary.log, before libcxxwrap broke due to a different change, see JuliaInterop/libcxxwrap-julia#137)
This error seems to come from: https://github.com/JuliaLang/julia/pull/51764/files#diff-2331196f664261004e7d661fc57c6076578eeebc0bb8ef941e1c9f4215d72c90
Stepping through the code with two different julia version from before and after this change I got for before:
and after (note the
Vector{Any}
instead ofAny
as third type for RefArray):And the new code then tried to call
Base.unsafe_convert(to_type::Type{<:CxxBaseRef}, x) = to_type(x.cpp_object)
instead of the one forRefArray
.Unfortunately the tests for this won't work for nightly due to the libcxxwrap error.
Edit: Locally this fixed the issue for julia nightly bde62adff7.