[breaking] Remove ConstraintTransformRegularization #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tknopp, as discussed, I implemented the ADMM and the SplitBregman to take
reg
andregTrafo
as separate arguments instead of merging them in aConstraintTransformRegularization
type. I further added documentation, to highlight this difference to the ISTA-type algorithms.Another little change I made on the way is to remove the
vec(reg)
function, as I find a a bit of an overkill and hard to read. Not sure, if it also boosts the need for recompilation since we're dispatching a Base function. I declared the function for now as deprecated, so this particular change is not (yet) breaking.As always, any comments are welcome!