increase accuracy of power iterations and remove flag normalize_rho
#86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tknopp,
I increased the default accuracy of the power iterations to ensure the correction step size of FISTA, optISTA, POGM reconstuctions.
I also changed the interface by removing the
normalize_rho
flag and building the power iterations into the default call ofrho
, increasing the flexibility to modify the settings of the power iterations as needed.Any chance you could give me a quick thumbs up on this, I would like to go ahead and release this code, as we want to start a bunch of recons with it, and I would prefer not doing this on branch that less permanence than are release.
Many thanks and have a great weekend!