Start playing with building the libpoplar wrapper in CI #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation of the wrapper library is moved to a `deps/build.jl` script, so that it can be done more automatically.
This is a temporary hack until I figure out how to properly serialise the numerical types, which have non-static properties.
Under the hood these aren't static objects that can be safely serialised, so we need to define them as dynamic accessor methods. Fix #1.
`Poplar.jl` is now a submodule of the package, the one providing the interface to the Poplar SDK.
Slightly more descriptive name. Also, index directory where the library is built by version of julia, so that we can make multiple versions co-exists.
giordano
force-pushed
the
mg/build-libpoplar
branch
21 times, most recently
from
285e742 to
8240b5f
Compare
|
Small update: the current state is working and all the tests (using hardware IPU) are passing when using the library compiled in CI. The proof-of-concept is definitely successful! |
giordano
force-pushed
the
mg/build-libpoplar
branch
from
8240b5f to
19fea2a
Compare
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for #18.
Still lots to do:
template.cppto the compiler, so it was building an empty library. Now I have some compilation errors, but it's good, it means it's trying to actually compile the right file)-I{includedir}/juli