Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining reference to g++-10 #19

Closed
wants to merge 3 commits into from

Conversation

owainkenwayucl
Copy link
Contributor

It appears I messed up last time (see #17) and there was another reference to g++-10 elsewhere in build.jl.

Sorry!

@giordano
Copy link
Collaborator

I think this is a good indication there should have been a single place where to handle the compiler setting 😬 I opened #20 as an alternative to this PR, which I prefer, but thanks for catching this! I haven't given much love to the build script and am planning to eventually get rid of it completely with #18 anyway.

@giordano giordano closed this in #20 Jul 18, 2023
@giordano giordano added the build Related to the build process label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants