Skip to content

Commit

Permalink
Build also for Poplar SDK v3.3
Browse files Browse the repository at this point in the history
  • Loading branch information
giordano committed Apr 9, 2024
1 parent 14a1f59 commit fc0ba90
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
18 changes: 17 additions & 1 deletion .github/workflows/build_libpoplar.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
matrix:
include:
- docker_image: graphcore/poplar:3.2.0-ubuntu-20.04-20230314
artifact_name: poplar-3.2.0
- docker_image: graphcore/poplar:3.3.0-ubuntu-20.04-20230703
artifact_name: poplar-3.3.0
steps:
- name: "Install, g++, jq"
# g++ is needed to build the wrapper, jq for
Expand All @@ -32,6 +35,19 @@ jobs:
with:
version: "1.7"
- uses: julia-actions/cache@v1
- name: "Export environment variables"
# Starting from graphcore/poplar:3.3.0 some environment variables like `CPATH` and
# `LD_LIBRARY_PATH`, which we need for building the bindings, are only set with the
# `bash` shell, while GHA uses by default `sh` for steps inside containers. So we
# need to start a step with `shell: bash` and re-export the relevant variables for
# the following steps.
shell: bash
run: |
echo "PATH=${PATH}" >> "${GITHUB_ENV}"
echo "CPATH=${CPATH}" >> "${GITHUB_ENV}"
echo "LIBRARY_PATH=${LIBRARY_PATH}" >> "${GITHUB_ENV}"
echo "LD_LIBRARY_PATH=${LD_LIBRARY_PATH}" >> "${GITHUB_ENV}"
echo "POPLAR_SDK_ENABLED=${POPLAR_SDK_ENABLED}" >> "${GITHUB_ENV}"
- name: Instantiate wrapper generation environment
working-directory: ${{ github.workspace }}/deps
run: |
Expand All @@ -54,5 +70,5 @@ jobs:
julia --project=. --color=yes build_tarballs.jl --verbose
- uses: actions/upload-artifact@v4
with:
name: products
name: products-${{ matrix.artifact_name }}
path: ${{ github.workspace }}/deps/bb_recipe/products
2 changes: 1 addition & 1 deletion deps/Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
libcxxwrap_julia_jll = "3eaa8342-bff7-56a5-9981-c04077f7cee7"

[compat]
Clang = "0.14, 0.17.4"
Clang = "0.14, 0.17.4, 0.18"
JSON = "0.21.4"
Pkg = "1"
Scratch = "1.1"
Expand Down

0 comments on commit fc0ba90

Please sign in to comment.