Skip to content

Commit

Permalink
Go back to C++17 to build the wrapper
Browse files Browse the repository at this point in the history
  • Loading branch information
giordano committed Jun 18, 2024
1 parent 960b7da commit 7688bac
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
# the `julia-actions/cache` workflow
run: |
apt-get update -y
apt-get install -y g++-10 git jq
apt-get install -y g++ git jq
env:
DEBIAN_FRONTEND: noninteractive
- uses: actions/checkout@v4
Expand All @@ -55,12 +55,9 @@ jobs:
cache-packages: "true"
cache-compiled: "true"
- uses: julia-actions/julia-buildpkg@v1
env:
CXX: g++-10
- uses: julia-actions/julia-docdeploy@v1
if: ${{ matrix.build_docs }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }}
CXX: g++-10
- uses: julia-actions/julia-runtest@v1
3 changes: 2 additions & 1 deletion deps/build.jl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ function build_bindings(; path::String=joinpath(libpoplar_dir, "libpoplar_julia.
run(```
$(cxx)
-O0
-std=c++2a
-std=c++17
-DJLCXX_FORCE_RANGES_OFF
-fPIC
-shared
-I$(julia_include_dir)
Expand Down
2 changes: 1 addition & 1 deletion docs/src/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ This package requires

* Julia v1.6+ (currently tested up to Julia v1.10),
* the Poplar SDK v1.3 or v2.0-v3.2 including the `popc` compiler,
* a C++ compiler supporting C++20 standard for compiling the wrapper around the Poplar SDK (e.g. G++ 10 or following releases).
* a C++ compiler supporting C++17 standard for compiling the wrapper around the Poplar SDK (e.g. G++ 9 or following releases).

Other versions of the Poplar SDK are not currently supported.

Expand Down

0 comments on commit 7688bac

Please sign in to comment.