Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check size of the central directory is correct when reading #82

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Oct 7, 2024

Previously, the "size of the central directory" was not checked when reading an archive because this information is redundant in a correctly formatted archive. By adding in these checks, invalid archives can be rejected earlier.

With this change, some invalid archives that could be read before can no longer be read.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (96de730) to head (36ecbf0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   99.74%   99.75%           
=======================================
  Files           6        6           
  Lines         792      801    +9     
=======================================
+ Hits          790      799    +9     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhz2 nhz2 marked this pull request as ready for review October 7, 2024 17:00
@nhz2 nhz2 merged commit 4f080a9 into main Oct 7, 2024
18 checks passed
@nhz2 nhz2 deleted the more-central-dir-checks branch October 7, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant