Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make T{typeof(f)}() loadable again #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kshramt
Copy link

@kshramt kshramt commented Feb 11, 2017

This patch fixes a regression introduced by 94af823.
Now the return value of Optim.optimize is loadable again.

This patch fixes a regression introduced by 94af823.
Now the return value of `Optim.optimize` is `load`able again.
@kshramt
Copy link
Author

kshramt commented Feb 11, 2017

CI failures seem to be unrelated.

@vtjnash
Copy link
Contributor

vtjnash commented Jul 17, 2017

This should be fixed with a custom Symbol printer at locations such as
https://github.com/kshramt/JLD.jl/blob/071d0e16d3d44a0f29e5f0d9b1126246e4d1694e/src/JLD.jl?utf8=✓#L1127
which prints out getfield(mod.path, Symbol("name")) instead of mod.path.name when name can't be represented as a Symbol. (for bonus points, it could also write mod.path.#sin as typeof(mod.path.sin), but that's not strictly necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants