Skip to content

Commit

Permalink
Merge pull request #331 from mkitti/mkitti-fix-dataspace
Browse files Browse the repository at this point in the history 
Fix use of HDF5._dataspace
  • Loading branch information
@mkitti
mkitti authored Mar 24, 2024
2 parents e2ed6e9 + e694b8c commit 80ac896
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "JLD"
uuid = "4138dd39-2aa7-5051-a626-17a0bb65d9c8"
version = "0.13.4"
version = "0.13.5"

[deps]
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
Expand Down
4 changes: 2 additions & 2 deletions src/JLD.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ function getindex(dset::JldDataset, indices::Union{AbstractRange{Int},Integer}..
sz = map(length, indices)
dsel = HDF5.hyperslab(dset.plain, indices...)
try
dspace = HDF5._dataspace(sz)
dspace = HDF5.dataspace(sz)
try
return read_array(dset, datatype(dset.plain), dspace.id, dsel.id, sz)
finally
Expand Down Expand Up @@ -791,7 +791,7 @@ function setindex!(dset::JldDataset, X::AbstractArray{T,N}, indices::Union{Abstr
buf = h5convert_array(f, convert(Array{written_eltype,N}, X), jldtype,
JldWriteSession())

dspace = HDF5._dataspace(sz)
dspace = HDF5.dataspace(sz)
try
HDF5.API.h5d_write(dset.plain.id, dtype, dspace, dsel_id, HDF5.API.H5P_DEFAULT, buf)
finally
Expand Down

2 comments on commit 80ac896

@mkitti
Copy link
Member Author

@mkitti mkitti commented on 80ac896 Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/103505

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.13.5 -m "<description of version>" 80ac89643e3ad87545e48f4d361a00a29cdf4e2f
git push origin v0.13.5

Please sign in to comment.