Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implementation of substructure modules #87
base: main
Are you sure you want to change the base?
[WIP] Implementation of substructure modules #87
Changes from 3 commits
10d0c6b
d80ffed
769b555
b23118c
3d4220b
094b34e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 13 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L13
Check warning on line 17 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L15-L17
Check warning on line 20 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L19-L20
Check warning on line 36 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L36
Check warning on line 39 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L38-L39
Check warning on line 43 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L41-L43
Check warning on line 45 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L45
Check warning on line 52 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L50-L52
Check warning on line 55 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L54-L55
Check warning on line 74 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L72-L74
Check warning on line 76 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still find the need for this function questionable. You can just replace it with
sort!(event_jet_array, by = pt2, rev = true)
so it's really not needed.
Check warning on line 81 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L79-L81
Check warning on line 86 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L85-L86
Check warning on line 90 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L88-L90
Check warning on line 92 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can cut this line - say everything in the doctoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove blank line. (It may even cause trouble?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment for variable names - prefer lowercase and
_
s if needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove blank line
Check warning on line 175 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L173-L175
Check warning on line 178 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L177-L178
Check warning on line 182 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L180-L182
Check warning on line 186 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L184-L186
Check warning on line 190 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L189-L190
Check warning on line 192 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L192
Check warning on line 196 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L196
Check warning on line 199 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L199
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove blank line
Check warning on line 221 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L219-L221
Check warning on line 224 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L223-L224
Check warning on line 227 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L226-L227
Check warning on line 231 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L229-L231
Check warning on line 234 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L233-L234
Check warning on line 238 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L236-L238
Check warning on line 242 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L241-L242
Check warning on line 244 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L244
Check warning on line 248 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L248
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not completely convinced by this return type - it might be better in this case to return
nothing
. But we need to check this is ok from a performance point of view. Could you check that?Check warning on line 251 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L251
Check warning on line 272 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L269-L272
Check warning on line 275 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L274-L275
Check warning on line 277 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L277
Check warning on line 279 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L279
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove blank
Check warning on line 299 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L296-L299
Check warning on line 302 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L301-L302
Check warning on line 307 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L304-L307
Check warning on line 310 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L309-L310
Check warning on line 312 in src/Substructure.jl
Codecov / codecov/patch
src/Substructure.jl#L312