Change generic method name to jet_reconstruct
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to have the prefix `generic`
Update the README to show how to ruin reconstruction
using the "Best" strategy (should be the default way)
Add also a note on sorting (which is super trivial in Julia,
so no need to support specific methods for
`Vector{PseudoJet}` as fastjet does)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to have the prefix
genericon the main interface, it's simpler just to call itjet_reconstruct.Update the README to show how to run reconstruction using the "Best" strategy (this is the default way).
Add also a note on sorting (which is super trivial in Julia, so no need to support specific methods for
Vector{PseudoJet}as fastjet does).