Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority to map #110

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Add priority to map #110

merged 4 commits into from
Nov 6, 2023

Conversation

ffreyer
Copy link
Contributor

@ffreyer ffreyer commented Sep 24, 2023

This adds the priority keyword to map.

I think I made these changes alongside MakieOrg/Makie.jl#3084 but forgot to open a pr. Without them lift and map are inconsistent between the map(f, scene/plot, obs...) and map(f, obs...) versions, as one supports priority and the other does not.
Will fix map/priority related errors in MakieOrg/Makie.jl#3246.

@SimonDanisch Would be good to have this merged before the next Makie release

@SimonDanisch
Copy link
Member

We should also add update=true/false to onany while at it

@SimonDanisch SimonDanisch merged commit f01cc59 into JuliaGizmos:master Nov 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants