Remove dependency on Statistics and src/mean.jl
#255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 88.82% 89.51% +0.69%
==========================================
Files 16 15 -1
Lines 1602 1593 -9
==========================================
+ Hits 1423 1426 +3
+ Misses 179 167 -12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you for the improvement @hyrodium 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mean_rotationshould be implemented in the future (#178), but it does not imply adding methods toStatistics.mean.This PR removes the unnecessary dependency on Statistics.jl and remove
src/mean.jlfor now.