Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs/src/examples/basics.md page #134

Merged
merged 17 commits into from
Feb 5, 2024

Conversation

hyrodium
Copy link
Collaborator

@hyrodium hyrodium commented Nov 6, 2023

fix #45, fix #127

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf3803b) 100.00% compared to head (1873339) 100.00%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          173       173           
=========================================
  Hits           173       173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/make.jl Outdated Show resolved Hide resolved
docs/src/examples/basics.md Outdated Show resolved Hide resolved
docs/src/examples/basics.md Outdated Show resolved Hide resolved
docs/src/examples/basics.md Outdated Show resolved Hide resolved

The type parameter `T <: Real` in `Quaternion{T}` represents the type of real and imaginary parts of a quaternion.

### Lipschitz quaternions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these quaternion types are niche and probably not of interest to nearly all of our users. So perhaps it would be better to not include them in basics.md and instead put them in a docs page devoted to specialized quaternion types.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added type_parameter.md page.

docs/src/examples/basics.md Outdated Show resolved Hide resolved
docs/src/examples/basics.md Outdated Show resolved Hide resolved
docs/src/examples/basics.md Outdated Show resolved Hide resolved
docs/src/examples/basics.md Outdated Show resolved Hide resolved
Note that `Base.Complex` has the same type parameter restriction, and [bicomplex numbers](https://en.wikipedia.org/wiki/Bicomplex_number) are not supported in Base.
See [issue#79](https://github.com/JuliaGeometry/Quaternions.jl/issues/79) for more discussion.

## Compatibility with `Complex`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this does feel like it belongs here.

@@ -0,0 +1,141 @@
# Basics

## Basic operations for quaternions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like sign should be somewhere discussed here as the right approach for constructing a unit quaternion.

@hyrodium hyrodium marked this pull request as ready for review November 25, 2023 13:01
@hyrodium hyrodium changed the title Add docs/src/basics.md Add docs/src/examples/basics.md page Nov 25, 2023
@hyrodium hyrodium requested a review from sethaxen November 25, 2023 13:35
@hyrodium hyrodium mentioned this pull request Feb 3, 2024
@hyrodium hyrodium merged commit 6d90f17 into JuliaGeometry:main Feb 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants