Rebase of #125 (Imaging mode for native code) #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right the issue here is that the Julia C++ code itself doesn't expose the necessary information so this doesn't help with really anything. I have a PR open where I make this orthogonal from the native vs extern mode. Essentially we need to hoist more of the loop into GPUCompiler to enable interesting use cases |
|
I'm not sure how necessary this is anymore. The only differences from imaging to non imagining now I think are the PTLS emission, ccalls and multiversioning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it's just a simple rebase + actually turning on imaging mode. There are still some issues such as const globals being turned into null pointers instead of the actual values.