Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement missing LinearAlgebra wrappers and add support for uplo parameter" #70

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 26, 2023

Reverts #51. This breaks CUDA.jl:

julia> using CUDA
Precompiling CUDA
  6 dependencies successfully precompiled in 20 seconds. 60 already precompiled.

julia> A = CUDA.rand(2,2)
2×2 CuArray{Float32, 2, CUDA.Mem.DeviceBuffer}:
 0.523348  0.920557
 0.283318  0.778918

julia> using LinearAlgebra

julia> cholesky(Hermitian(A*A'+I, :L), NoPivot())
ERROR: a exception was thrown during kernel execution.
Stacktrace:
 [1] setindex! at /cache/build/default-amdci5-7/julialang/julia-release-1-dot-10/usr/share/julia/stdlib/v1.10/LinearAlgebra/src/symmetric.jl:264
 [2] _setindex! at ./abstractarray.jl:1424
 [3] setindex! at ./abstractarray.jl:1389
 [4] linear_copy_kernel! at /home/tim/.julia/packages/GPUArrays/EZkix/src/host/abstractarray.jl:180

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4f8952b) 77.77% compared to head (6cd90b0) 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   77.77%   83.33%   +5.55%     
==========================================
  Files           6        6              
  Lines          81       72       -9     
==========================================
- Hits           63       60       -3     
+ Misses         18       12       -6     
Files Coverage Δ
src/wrappers.jl 72.22% <58.82%> (+7.77%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit fa59c4c into master Oct 26, 2023
15 checks passed
@maleadt maleadt deleted the revert-51-wrappers branch October 26, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant