Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Use LanguageServer.jl for better completions #413

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quangIO
Copy link

@quangIO quangIO commented Jul 28, 2019

ref #338
This is a very buggy PoC obviously

@ice1000 ice1000 added the language server Give up writing a complete analyzer label Jul 28, 2019
Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sticky fingers

}
dependencies {
compile("org.jetbrains", "markdown", "0.1.31")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you eliminate these whitespaces changes?

<moduleConfigurationEditorProvider implementation="org.ice1000.julia.lang.module.JuliaModuleConfigEditor"/>
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@@ -54,12 +56,28 @@
<stubIndex implementation="org.ice1000.julia.lang.psi.JuliaAbstractTypeDeclarationIndex"/>
<stubIndex implementation="org.ice1000.julia.lang.psi.JuliaTypeDeclarationIndex"/>
<stubIndex implementation="org.ice1000.julia.lang.psi.JuliaModuleDeclarationIndex"/>
<localInspection displayName="LSP"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the display name be changed to "language server" or "julia language server"?

<completion.contributor
language="Julia"
implementationClass="org.ice1000.julia.lang.editing.JuliaBasicCompletionContributor"/>
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep this, no?

@@ -95,4 +98,4 @@ class JuliaCompileOutputEditor(state: ModuleConfigurationState) : ModuleElements
override fun getDisplayName() = "Paths"
override fun getHelpTopic() = editor.helpTopic
}

*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@quangIO
Copy link
Author

quangIO commented Aug 16, 2019

I am quite busy with my job/study recently. This is just a PoC. If you'd like to take over this, feel free to just use the working parts and close this PR.
The autocompletion just for testing purpose. Module codes do not work with the latest version of Intellij platform. The script to run language server is included but not integrated (note there is a minor syntax error in that too).

@ice1000
Copy link
Member

ice1000 commented Aug 16, 2019

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language server Give up writing a complete analyzer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants