Create new files instead of copying internal resources. (#1497)

JuliaDocs · Dec 16, 2020 · ee0d535 · ee0d535 · fredrikekre · Dec 16, 2020
1 parent b68e2d9
commit ee0d535
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Documenter.jl changelog
 
+## Version `v0.26.1`
+
+* ![Bugfix][badge-bugfix] HTML assets that are copied directly from Documenters source to the build output now has correct file permissions. ([#1497][github-1497])
+
 ## Version `v0.26.0`
 
 * ![BREAKING][badge-breaking] The PDF/LaTeX output is again provided as a Documenter built-in and can be enabled by passing an instance of `Documenter.LaTeX` to `format`. The DocumenterLaTeX package has been deprecated. ([#1493][github-1493])
@@ -717,6 +721,7 @@
 [github-1489]: https://github.com/JuliaDocs/Documenter.jl/pull/1489
 [github-1491]: https://github.com/JuliaDocs/Documenter.jl/pull/1491
 [github-1493]: https://github.com/JuliaDocs/Documenter.jl/pull/1493
+[github-1497]: https://github.com/JuliaDocs/Documenter.jl/pull/1497
 
 [julia-38079]: https://github.com/JuliaLang/julia/issues/38079
 

diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "Documenter"
 uuid = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
-version = "0.26.0"
+version = "0.26.1"
 
 [deps]
 Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"

diff --git a/src/Writers/HTMLWriter.jl b/src/Writers/HTMLWriter.jl
@@ -707,7 +707,10 @@ function copy_asset(file, doc)
     else
         ispath(dirname(dst)) || mkpath(dirname(dst))
         ispath(dst) && @warn "overwriting '$dst'."
-        cp(src, dst, force=true)
+        # Files in the Documenter folder itself are read-only when
+        # Documenter is Pkg.added so we create a new file to get
+        # correct file permissions.
+        open(io -> write(dst, io), src, "r")
     end
     assetpath = normpath(joinpath("assets", file))
     # Replace any backslashes in links, if building the docs on Windows