Format code with JuliaFormatter
#256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add format checking workflows
devmotion
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Before we format the code base, we have to agree on a code style. IMO we shouldn't rely on general defaults of JuliaFormatter but fix the style that's agreed on in a .JuliaFormatter.toml file in the repo.
I tend to use blue style (as e.g. ChainRulesCore: https://github.com/JuliaDiff/ChainRulesCore.jl/blob/main/.JuliaFormatter.toml) but there are of course other common styles.
devmotion
reviewed
Apr 23, 2024
Co-authored-by: David Widmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formats the code with
JuliaFormatterand adds a couple of format checking workflows.