-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only define rules for SpecialFunctions if needed #320
Conversation
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 18 18
Lines 988 988
=======================================
Hits 963 963
Misses 25 25
Continue to review full report at Codecov.
|
Yes let's add this to the tests and bump the version also It will be nice for the tests and we won't see the deprecation warnings. Can you also open an issue about dropping the SpecialFunctions dependency and cross link that in the code? |
Great! Ideally, I'd like to delay tagging a new SpecialFunctions release until this is merged and tagged in ChainRules, so it would be good if you could do a 0.7.35 release with this in the near future. |
Will do tomorrow |
This PR addresses #319 by only defining rules for SpecialFunctions if SpecialFunctions.ChainRulesCore does not exist, as suggested by @oxinabox in JuliaMath/SpecialFunctions.jl#238 (comment).
Should the same condition be added to the tests? And do you want me to bump the version?