Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: psubscribe method issues #102

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: psubscribe method issues #102

merged 1 commit into from
Dec 11, 2023

Conversation

tanmaykm
Copy link
Member

@tanmaykm tanmaykm commented Dec 4, 2023

depends on #100
fixes #101

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b76a05f) 73.88% compared to head (91ded87) 80.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   73.88%   80.21%   +6.32%     
==========================================
  Files           6        6              
  Lines         360      369       +9     
==========================================
+ Hits          266      296      +30     
+ Misses         94       73      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkaye2012
Copy link
Collaborator

Give #100 is merged, should we look at this one as well?

- reduce specialization of `psubscribe` and `subscribe` method signatures
- fix typo in call to `_psubscribe`
- introduced `psubscribe_data` similar to what was done in #95
- improve tests for `psubscribe` and `subscribe`

depends on #100
fixes #101
@tanmaykm tanmaykm marked this pull request as ready for review December 11, 2023 20:23
@tanmaykm
Copy link
Member Author

Thanks @jkaye2012 !
I have rebased and this is ready for review.

@jkaye2012 jkaye2012 merged commit fcd0353 into master Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

psubscribe method issues
2 participants