Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI.yml to use pre-release builds #564

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Update CI.yml to use pre-release builds #564

merged 2 commits into from
Sep 10, 2024

Conversation

ViralBShah
Copy link
Contributor

Using pre instead of nightly. Thoughts?

Using `pre` instead of `nightly`.
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (275cd2e) to head (33aa1e2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   97.74%   97.84%   +0.09%     
==========================================
  Files          18       18              
  Lines        3199     3199              
==========================================
+ Hits         3127     3130       +3     
+ Misses         72       69       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinholters
Copy link
Member

I'm on board with nightly -> pre. But the 1.6 -> lts change seems problematic to me, as that means we will eventually stop testing on anything older than 1.10, while still claiming compatibility with 1.6 onward. Better manually bump the lowest version in Project.toml and for CI in lockstep IMHO.

@ViralBShah ViralBShah merged commit 96e6381 into master Sep 10, 2024
8 checks passed
@ViralBShah ViralBShah deleted the vs/ci branch September 10, 2024 14:48
@ViralBShah ViralBShah changed the title Update CI.yml to use LTS and pre-release builds Update CI.yml to use pre-release builds Sep 10, 2024
martinholters added a commit that referenced this pull request Sep 13, 2024
martinholters added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants