Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polynomials compat to include v4 #507

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Aug 31, 2023

Let's see if the tests pass with this

@jishnub
Copy link
Contributor Author

jishnub commented Sep 13, 2023

Gentle bump @martinholters

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (90fe256) 97.29% compared to head (1c89c02) 97.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          18       18           
  Lines        3105     3105           
=======================================
  Hits         3021     3021           
  Misses         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, so I guess this should be ok, though I haven't checked what changes Polynomials v4 brings along.
Unless anyone objects, I'll merge tomorrow (or whenever I'm reminded in case I forget).

@martinholters martinholters merged commit 3e3524f into JuliaDSP:master Sep 14, 2023
8 checks passed
@jishnub jishnub deleted the patch-3 branch September 14, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants