Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bode plot with zero magnitude #911

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix Bode plot with zero magnitude #911

merged 1 commit into from
Dec 15, 2023

Conversation

baggepinnen
Copy link
Member

Closes #438

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e8f68d6) 92.87% compared to head (5360a25) 92.83%.

Files Patch % Lines
lib/ControlSystemsBase/src/plotting.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
- Coverage   92.87%   92.83%   -0.04%     
==========================================
  Files          43       43              
  Lines        4813     4815       +2     
==========================================
  Hits         4470     4470              
- Misses        343      345       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@baggepinnen baggepinnen merged commit ecd97f3 into master Dec 15, 2023
4 of 6 checks passed
@baggepinnen baggepinnen deleted the discbodefix branch December 15, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrete bode default axis ranges
2 participants