Merge pull request #672 from YingboMa/myb/top

Add `top` deprecation
JuliaCollections · Sep 2, 2020 · 377a9bb · 377a9bb · oxinabox · Sep 2, 2020
2 parents 5c433f7 + 659f89a
commit 377a9bb
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 5 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -20,6 +20,8 @@ after_success:
 # Documenter auto-deploy
 # https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#.travis.yml-Configuration-1
 jobs:
+  allow_failures:
+    - julia: nightly
   include:
     - name: "Benchmark"
       julia: 1.2

diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "DataStructures"
 uuid = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
-version = "0.18.2"
+version = "0.18.3"
 
 [deps]
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"

diff --git a/appveyor.yml b/appveyor.yml
@@ -9,9 +9,9 @@ platform:
 
 ## uncomment the following lines to allow failures on nightly julia
 ## (tests will run but not make your overall status red)
-#matrix:
-#  allow_failures:
-#  - julia_version: latest
+matrix:
+  allow_failures:
+  - julia_version: latest
 
 branches:
   only:

diff --git a/src/DataStructures.jl b/src/DataStructures.jl
@@ -112,4 +112,4 @@ module DataStructures
     include("splay_tree.jl")
 
     include("deprecations.jl")
-end
+end
diff --git a/src/deprecations.jl b/src/deprecations.jl
@@ -1,3 +1,4 @@
 # 0.18 deprecations. Remove before releasing 0.19
 @deprecate path(t::Trie, str::AbstractString) partial_path(t::Trie, str::AbstractString)
 @deprecate find_root find_root!
+@deprecate top first
diff --git a/test/test_deprecations.jl b/test/test_deprecations.jl
@@ -14,4 +14,9 @@
     @test collect(path(t, "robb")) == [t0, t1, t2, t3]
     @test collect(path(t, "ro")) == [t0, t1, t2]
     @test collect(path(t, "roa")) == [t0, t1, t2]
+end
+
+@testset "top" begin
+    hh = BinaryMinHeap{Float64}([1,2,3])
+    @test top(hh) == 1
 end