Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow loading saved benchmark results from version <= 1.3.2 #351

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Allow loading saved benchmark results from version <= 1.3.2 #351

merged 7 commits into from
Jan 17, 2024

Conversation

Zentrik
Copy link
Contributor

@Zentrik Zentrik commented Jan 4, 2024 •
edited
Loading

After evals_set was added to the Parameters struct, it no longer was possible to load old files. Given the simplicity of the fix seems worthwhile.

I set the default to false, as that seems to replicate the behaviour of BenchmarkTools before this field was added.

gdalle
gdalle approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gdalle gdalle merged commit 8dcac4d into JuliaCI:master Jan 17, 2024
9 checks passed
Zentrik added a commit to Zentrik/BenchmarkTools.jl that referenced this pull request Feb 1, 2024
@Zentrik
Allow loading saved benchmark results from version <= 1.3.2 (JuliaCI#351
fa92620 
)

* Allow loading saved files without evals_set parameter

* Fix parsing

* Fix scoping in test

* Fix typo

* Fix bug

* Fix typo

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdalle gdalle gdalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zentrik @gdalle