Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid underflow and overflow in norm() #975

Merged
merged 21 commits into from
Feb 6, 2023
Merged

Avoid underflow and overflow in norm() #975

merged 21 commits into from
Feb 6, 2023

Commits on Dec 6, 2021

  1. Avoid underflow in norm()

    @wsshin
    wsshin committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    44ba6f0 View commit details
    Browse the repository at this point in the history

  2. Perform return-type assertion at last step

    @wsshin
    wsshin committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    1b45376 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Make _init_zero() take AbstractArray

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    7a81561 View commit details
    Browse the repository at this point in the history

  2. Define maxabs_nested() to find maximum of absolute values of entries … 

    …in nested array
    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    d553e15 View commit details
    Browse the repository at this point in the history

  3. Remove _norm() and define norm() directly for type stability

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    22739f7 View commit details
    Browse the repository at this point in the history

  4. Use maxabs_nested() to define norm() stably without underflow

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    0f498a5 View commit details
    Browse the repository at this point in the history

  5. Call _init_zero() without qualification by StaticArrays

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ff314a1 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into norm-nuf

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    4e580c3 View commit details
    Browse the repository at this point in the history

  7. Define norm_scaled() and call it inside norm()

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    e75bad8 View commit details
    Browse the repository at this point in the history

  8. norm(a,p) does not call norm_scaled(a,p) if p == 0, 2, Inf

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    f33208a View commit details
    Browse the repository at this point in the history

  9. Make code more succinct

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    629d020 View commit details
    Browse the repository at this point in the history

  10. Use normInf() instead of maxabs_nested()

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    2e3c6b6 View commit details
    Browse the repository at this point in the history

  11. Rename aₘ to scale

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    146d0e9 View commit details
    Browse the repository at this point in the history

  12. Calculate scale with mapreduce()

    @wsshin
    wsshin committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    90e7c70 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2022

  1. Re-introduce maxabs_nested to avoid type instability

    @wsshin
    wsshin committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    e44647c View commit details
    Browse the repository at this point in the history

  2. norm() calls _norm() and _norm_scaled()

    @wsshin
    wsshin committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    0217203 View commit details
    Browse the repository at this point in the history

  3. _norm_scaled(Size(a), a, p) does not need to deal with p==2

    @wsshin
    wsshin committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    2a66d8e View commit details
    Browse the repository at this point in the history

  4. Add test for overflow

    @wsshin
    wsshin committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    51cdb73 View commit details
    Browse the repository at this point in the history

  5. Add tests for underflow and overflow for p ≥ 2

    @wsshin
    wsshin committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    921da59 View commit details
    Browse the repository at this point in the history

  6. Avoid using iszero(l) and isinf(l) for speedup

    @wsshin
    wsshin committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    9ea186b View commit details
    Browse the repository at this point in the history

  7. Avoid using iszero(scale) for speedup

    @wsshin
    wsshin committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    5cb4bdc View commit details
    Browse the repository at this point in the history