Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow vcat with leading infinite range #135

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 28, 2023

As discussed in #108, these perhaps aren't well-defined, and adding such methods opens one up to method ambiguities. In this light, it's best to not define these methods.

After this,

julia> [1:∞; 1]
ERROR: ArgumentError: vcat is undefined with a leading infinite range

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #135 (ba0ba0e) into master (923fc66) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   85.69%   85.46%   -0.23%     
==========================================
  Files           5        5              
  Lines         706      695      -11     
==========================================
- Hits          605      594      -11     
  Misses        101      101              
Files Changed Coverage Δ
src/infrange.jl 87.50% <100.00%> (-0.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty dlfivefifty merged commit 223b1b6 into JuliaArrays:master Jul 28, 2023
@jishnub jishnub deleted the disallowinfvcat branch July 28, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants