-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operators for higher dimensional Tensorspaces #390
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 65.66% 60.89% -4.77%
==========================================
Files 79 80 +1
Lines 8323 8547 +224
==========================================
- Hits 5465 5205 -260
- Misses 2858 3342 +484 ☔ View full report in Codecov by Sentry. |
I think this is the right approach. Also, the CI is probably broken right now because of FFTW v1.6, but hopefully that should be fixed soon |
The following works now:
What is missing is
which is because there is no Iterator for the Tensorizer of the space |
The implementation is finished, but tests are missing. I feel like most of the test are necessary in ApproxFunOrthogonalPolynomials.jl and here maybe some for the KroneckerOperator. |
Could you look into the test failures? The CI issue should be resolved now |
See #389
I modified the
KroneckerOperator
temporarily to allow for tuples with more than 2 entries:I am not sure how to change this, maybe by changing the signature to
where
TT
is than the tuple typeT{S,V,D,...}
.What now works is the following: