Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orthogonalize maxspace/union for ConstantSpace #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 10, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Base: 71.76% // Head: 43.75% // Decreases project coverage by -28.00% ⚠️

Coverage data is based on head (a4d5c9b) compared to base (ba0c997).
Patch coverage: 70.58% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #327       +/-   ##
===========================================
- Coverage   71.76%   43.75%   -28.01%     
===========================================
  Files          79       79               
  Lines        8258     8252        -6     
===========================================
- Hits         5926     3611     -2315     
- Misses       2332     4641     +2309     
Impacted Files Coverage Δ
src/Space.jl 60.69% <70.58%> (-25.53%) ⬇️
src/onehotvector.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Multivariate/TrivialTensorFun.jl 0.00% <0.00%> (-96.00%) ⬇️
src/Operators/nullspace.jl 0.00% <0.00%> (-92.11%) ⬇️
src/Operators/almostbanded/LowRankOperator.jl 0.00% <0.00%> (-83.34%) ⬇️
src/Spaces/QuotientSpace.jl 3.44% <0.00%> (-78.74%) ⬇️
src/Domains/PiecewiseSegment.jl 11.76% <0.00%> (-72.55%) ⬇️
src/PDE/PDE.jl 20.51% <0.00%> (-64.11%) ⬇️
src/Operators/almostbanded/LowRankPertOperator.jl 0.00% <0.00%> (-63.34%) ⬇️
src/Operators/general/PartialInverseOperator.jl 41.07% <0.00%> (-57.15%) ⬇️
... and 61 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant