Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datatype to OneHotEncoder and ContinuousEncoder #566

Closed
wants to merge 1 commit into from

Conversation

tiemvanderdeure
Copy link
Contributor

allows users to specify what datatype OneHotEncoder and ContinuousEncoder return, so that this now works:

using MLJModels, MLJBase
X = (x = rand(10), c = categorical(rand(Bool, 10)))
mach = machine(ContinuousEncoder(datatype = Float32), X)
fit!(mach)
transform(mach, X)

see discussion here: #565

There is probably a way to fix this for ContinousEncoder without copying data around just as much. I'll figure that out if we decide to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant