Adding lock to control experiment creation during multiprocessing #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests required by #25, but also solves the issue presented in JuliaAI/MLFlowClient.jl#40.
Using
julia --threads 5
, each thread will continue its own processing until reaches thelog_evaluation
function. In that step, alock
(mutex) will turn the entire process into a sync one ensuring thread-safeness.Feature diagram: