Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added local lyrics with .lrc and Sync for lyrics #47

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

lecheel
Copy link

@lecheel lecheel commented Nov 25, 2024

lrc support sync with timestamp
Screenshot from 2024-11-25 20-51-02

Copy link
Author

@lecheel lecheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Author

@lecheel lecheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monkey test done

@Jugran
Copy link
Owner

Jugran commented Dec 6, 2024

Thank you for contributing to this project. I will review the changes and merge.

@Jugran Jugran changed the base branch from main to development December 6, 2024 17:20
@Jugran Jugran self-assigned this Dec 6, 2024
@Jugran Jugran added the enhancement New feature or request label Dec 6, 2024
@Jugran
Copy link
Owner

Jugran commented Dec 6, 2024

Looks like only reading of lrc files is supported and not fetching from lrclib.net.
I will be merging this to development branch for now and I will be lrclib as a new source for auto loading of synced lyrics.

@Jugran Jugran merged commit 2365ea5 into Jugran:development Dec 6, 2024
@lecheel
Copy link
Author

lecheel commented Dec 7, 2024

which retrive the local xxx_song.lrc for lyrics sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants