-
Notifications
You must be signed in to change notification settings - Fork 0
Adding manual scoring plugin #56
base: master
Are you sure you want to change the base?
Conversation
@@ -207,7 +207,7 @@ html, body | |||
min-height: 100%; | |||
height: auto !important; | |||
height: 100%; | |||
margin: 0 auto -81px; | |||
margin: 0 auto 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be achieved by overwriting the css rule inside a static file created inside the plugin's directory, avoid touching INGInious' codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lin99 please take a look at the comments
language = convertInginiousLanguageToCodemirror(language) | ||
|
||
|
||
var editor = getEditorForProblemId(problemId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use both spaces and tabs
# -*- coding: utf-8 -*- | ||
# | ||
# This file is part of INGInious. See the LICENSE and the COPYRIGHTS files for | ||
# more information about the licensing of this file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment shouldn't be here
@@ -0,0 +1,27 @@ | |||
import pandas as pd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this library isn't present in the setup.py "install_requires"
def read_data(self, source): | ||
return pd.read_excel(source, index_col=0, header=0) | ||
|
||
def load_data(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function is still loading dummy data, not real information obtained from the db.
|
||
#read data from source | ||
def read_data(self, source): | ||
return pd.read_excel(source, index_col=0, header=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this requires the library xlrd
this should also be added to the setup.py
|
||
|
||
#Listado de submissions | ||
class TaskListSubmissionPageTemp(INGIniousAdminPage): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this temp page being used? can't we remove this?
|
||
|
||
|
||
class SubmissionRubricPageTemp(INGIniousAdminPage): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another temporal class.
</div> | ||
<div class="panel-body"> | ||
<div class="student_view"> | ||
<p>print hi baker</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is hard coded, is this the task description?
$for index,row in rubrica.data.iterrows(): | ||
<tr> | ||
<th >$index</th> | ||
$for zeld in rubrica.data.columns.values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in "zeld"
@@ -0,0 +1,258 @@ | |||
$def with (course, task_id, submission_code, problem_id, rubrica, data, language) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change variable "rubrica" to "rubric".
No description provided.