Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ref: no-ref): update ng 19 #124

Closed
wants to merge 16 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,24 @@

Please check if your PR fulfills the following requirements:

- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

Expand All @@ -31,8 +31,8 @@ Issue Number: N/A

## Does this PR introduce a breaking change?

- [ ] Yes
- [ ] No
- [ ] Yes
- [ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Expand Down
2 changes: 1 addition & 1 deletion .github/hooks/commit-msg
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
set -e

commit_msg=$(cat .git/COMMIT_EDITMSG)
echo "$commit_msg" | npx commitlint
echo "$commit_msg" | bun commitlint
12 changes: 6 additions & 6 deletions .github/hooks/pre-commit
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@

set -e

npm run lint
bun lint-staged

npm run snyk:test
# bun run snyk:test

output=$(npm run type-coverage)
output=$(bun run type-coverage)
if echo "$output" | grep -q "lower than "; then
echo "$output"
exit 1 # Terminate the hook script with a non-zero exit code
else
echo "Type coverage is good! 🎉"
fi

npm run test
bun run test

npm run build
bun run build

npm run build:lib
bun run build:lib

16 changes: 10 additions & 6 deletions .github/workflows/gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,20 @@ jobs:
contents: write
steps:
- uses: actions/checkout@v4
with:
submodules: true

- uses: actions/setup-node@v4
with:
node-version: 20

- uses: oven-sh/setup-bun@v2
with:
bun-version: latest

- name: Install deps
run: |
npm ci --force
git submodule update --init --recursive --remote
bun i

- name: Semantic Release
id: semantic-release
Expand All @@ -37,14 +42,13 @@ jobs:
echo "RELEASE_VERSION: $RELEASE_VERSION"
echo '********'
bash .github/workflows/scripts/replace_template.sh $RELEASE_VERSION
npm run build
bun run build

- name: Deploy demo
uses: peaceiris/actions-gh-pages@v3
uses: peaceiris/actions-gh-pages@v4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./dist/angular-loader/browser

outputs:
version: ${{ steps.semantic-release.outputs.new-release-version }}

Expand All @@ -55,7 +59,7 @@ jobs:
steps:
- name: Post to a Slack channel
id: slack
uses: slackapi/slack-github-action@v1.26.0
uses: slackapi/slack-github-action@v1.27.0
with:
channel-id: 'deployments'
payload: |
Expand Down
18 changes: 11 additions & 7 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Publish npm
name: Publish bun

on:
push:
Expand All @@ -10,17 +10,21 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: true
- uses: oven-sh/setup-bun@v2
with:
bun-version: latest
- uses: actions/setup-node@v4
with:
node-version: 20
registry-url: https://registry.npmjs.org/
registry-url: 'https://registry.npmjs.org'
- name: Build library
run: |
npm ci --force
git submodule update --init --recursive --remote
npm run build:lib
bun i
bun run build:lib
- name: Publish library
run: npm run publish:lib
run: bun run publish:lib
env:
NODE_AUTH_TOKEN: ${{secrets.npm_token}}

Expand Down Expand Up @@ -63,7 +67,7 @@ jobs:
"type": "section",
"text": {
"type": "mrkdwn",
"text": "Website URL: ${{ secrets.WEBSITE_URL || 'TBA' }}"
"text": "Website URL: ${{ secrets.NPM_PACKAGE_URL || 'TBA' }}"
}
}
]
Expand Down
46 changes: 26 additions & 20 deletions .github/workflows/quality-check.yml
Original file line number Diff line number Diff line change
@@ -1,28 +1,34 @@
name: build and quality

on:
push:
branches:
- develop
pull_request:
branches:
- develop
push:
branches:
- develop
pull_request:
branches:
- develop

env:
snyk_token: ${{ secrets.SNYK_TOKEN }}
REF: ${{ github.head_ref || github.ref_name }}

jobs:
quality-check:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
- name: Check quality
run: |
npm ci --force
git submodule update --init --recursive --remote
bash .github/workflows/scripts/quality.sh
quality-check:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- uses: actions/checkout@v4
with:
submodules: true
ref: ${{ env.REF }}
- uses: oven-sh/setup-bun@v2
with:
bun-version: latest
- uses: actions/setup-node@v4
with:
node-version: 20
- name: Check quality
run: |
bun i
bash .github/workflows/scripts/quality.sh
14 changes: 7 additions & 7 deletions .github/workflows/scripts/quality.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@

set -e

npm run lint
bun run lint

npm run snyk:auth -- $snyk_token
npm run snyk:test
# bun run snyk:auth -- $snyk_token
# bun run snyk:test

output=$(npm run type-coverage)
output=$(bun run type-coverage)
if echo "$output" | grep -q "lower than "; then
echo "$output"
exit 1 # Terminate the hook script with a non-zero exit code
else
echo "Type coverage is good! 🎉"
fi

npm run test
bun run test

npm run build
bun run build

npm run build:lib
bun run build:lib
7 changes: 7 additions & 0 deletions .lintstagedrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"*.{ts,js,json}": [
"eslint --report-unused-disable-directives --max-warnings 0 --fix",
"prettier . --write"
],
"*.scss": "stylelint --fix"
}
8 changes: 4 additions & 4 deletions .releaserc.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
branches:
- develop
- develop

plugins:
- '@semantic-release/commit-analyzer'
- '@semantic-release/github'
- 'semantic-release-export-data'
- '@semantic-release/commit-analyzer'
- '@semantic-release/github'
- 'semantic-release-export-data'
11 changes: 10 additions & 1 deletion .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,23 @@
{
"extends": ["stylelint-config-recommended-scss"],
"customSyntax": "postcss-scss",
"plugins": ["stylelint-prettier"],
"plugins": ["stylelint-scss", "stylelint-prettier"],
"rules": {
"no-empty-source": null,
"scss/comment-no-empty": null,
"no-descending-specificity": null,
"prettier/prettier": true,
"selector-type-no-unknown": [
true,
{
"ignoreTypes": ["/^mat-/", "markdown", ":host", ":root"]
}
],
"scss/at-rule-no-unknown": [
true,
{
"ignoreAtRules": ["tailwind"]
}
]
}
}
35 changes: 24 additions & 11 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,50 +1,63 @@
# 19.0.0(2024-11-21)

### Feature

- update ng 19.x

# 18.0.4(2024-10-25)

### Feature

- add tailwind
- change interface to type, remove prefix "I"
- update dependencies
- add ESLint strict rules

# 17.3.2(2024-03-29)

### Feature

- change decorators to signals
- change decorators to signals

<a name="17.0.0"></a>

# 17.0.0(2023-11-28)

### Feature

- update ng 17.x
- update ng 17.x

<a name="17.0.0"></a>


# 16.0.1(2023-10-03)

### Feature

- update dependencies
- update dependencies

# 16.0.0(2023-07-07)

### Feature

- update ng 16.x
- update ng 16.x

<a name="16.0.0"></a>

# 15.0.0(2022-26-12)

### Feature
- update to ng15

<a name="15.0.0"></a>
- update to ng15

<a name="15.0.0"></a>

<a name="6.0.0"></a>
# [6.0.0 base functionality] (2018-05-17)

# [6.0.0 base functionality] (2018-05-17)

<a name="6.1.0"></a>

# [6.1.0 base functionality] (2018-05-21)

<p>Custom styles(background, color, size) for image and wrapper</p>
<p>Custom animations for image rotation</p>


Loading