Merge pull request #96 from JsDaddy/fix/test-commitlint

Fix/test commitlint
JsDaddy · Mar 26, 2024 · d5e4a9d · d5e4a9d
2 parents 5420f4b + c175e72
commit d5e4a9d
Show file tree

Hide file tree

Showing 24 changed files with 6,404 additions and 5,697 deletions.
diff --git a/.github/.hooks/commit-msg/check-commit-msg.sh b/.github/.hooks/commit-msg/check-commit-msg.sh
@@ -3,4 +3,5 @@
 set -e
 
 commit_msg=$(cat .git/COMMIT_EDITMSG)
-echo "$commit_msg" | npx  commitlint
+
+echo "$commit_msg" | npx  commitlint
diff --git a/.github/workflows/quality-check.yml b/.github/workflows/quality-check.yml
@@ -22,7 +22,4 @@ jobs:
         run: |
           npm ci --force
           git submodule update --init --recursive --remote
-          npm run lint
-          npm test
-          npm run build
-          npm run build:lib
+          bash .github/workflows/scripts/quality.sh
diff --git a/.stylelintrc.json b/.stylelintrc.json
@@ -1,7 +1,9 @@
 {
-    "extends": ["stylelint-config-recommended-scss", "stylelint-prettier/recommended"],
+    "extends": ["stylelint-config-recommended-scss"],
     "customSyntax": "postcss-scss",
+    "plugins": ["stylelint-prettier"],
     "rules": {
+        "prettier/prettier": true,
         "selector-type-no-unknown": [
             true,
             {

diff --git a/angular.json b/angular.json
@@ -2,74 +2,65 @@
     "$schema": "./node_modules/@angular/cli/lib/config/schema.json",
     "version": 1,
     "newProjectRoot": "projects",
+    "schematics": {
+        "@schematics/angular:component": {
+            "style": "scss",
+            "standalone": true,
+            "changeDetection": "OnPush",
+            "viewEncapsulation": "Emulated"
+        },
+        "@schematics/angular:directive": {
+            "standalone": true
+        },
+        "@schematics/angular:pipe": {
+            "standalone": true
+        },
+        "@schematics/angular:application": {
+            "strict": true
+        }
+    },
     "projects": {
         "angular-loader": {
             "root": "",
             "sourceRoot": "src",
             "projectType": "application",
             "prefix": "",
-            "schematics": {
-                "@schematics/angular:component": {
-                    "style": "scss",
-                    "standalone": true,
-                    "changeDetection": "OnPush",
-                    "viewEncapsulation": "ShadowDom"
-                },
-                "@schematics/angular:application": {
-                    "strict": true
-                }
-            },
             "architect": {
                 "build": {
                     "builder": "@angular-devkit/build-angular:application",
                     "options": {
                         "outputPath": "dist/angular-loader",
                         "browser": "src/main.ts",
                         "index": "src/index.html",
-                        "tsConfig": "src/tsconfig.app.json",
+                        "tsConfig": "tsconfig.app.json",
                         "assets": ["src/favicon.ico", "src/assets"],
                         "styles": [
                             "node_modules/highlight.js/styles/github.css",
                             "src/styles.scss"
                         ],
                         "scripts": [],
-                        "extractLicenses": false,
-                        "sourceMap": true,
-                        "optimization": false,
                         "namedChunks": true
                     },
                     "configurations": {
                         "production": {
                             "define": {
                                 "VERSION": "'<%version%>'"
                             },
-                            "optimization": true,
-                            "sourceMap": false,
-                            "namedChunks": false,
-                            "extractLicenses": true,
                             "budgets": [
                                 {
                                     "type": "initial",
-                                    "maximumWarning": "500kb",
-                                    "maximumError": "1mb"
+                                    "maximumWarning": "2mb",
+                                    "maximumError": "2mb"
                                 },
                                 {
                                     "type": "anyComponentStyle",
-                                    "maximumWarning": "9kb",
-                                    "maximumError": "10kb"
+                                    "maximumWarning": "15kb",
+                                    "maximumError": "15kb"
                                 }
                             ],
-                            "fileReplacements": [
-                                {
-                                    "replace": "src/environments/environment.ts",
-                                    "with": "src/environments/environment.prod.ts"
-                                }
-                            ]
+                            "outputHashing": "all"
                         },
                         "development": {
-                            "define": {
-                                "VERSION": "'v0.0.1'"
-                            },
                             "optimization": false,
                             "extractLicenses": false,
                             "sourceMap": true
@@ -88,22 +79,20 @@
                         }
                     }
                 },
-                "extract-i18n": {
-                    "builder": "@angular-devkit/build-angular:extract-i18n",
-                    "options": {
-                        "buildTarget": "angular-loader:build"
-                    }
-                },
                 "test": {
-                    "builder": "@angular-devkit/build-angular:karma",
+                    "builder": "@angular-devkit/build-angular:web-test-runner",
                     "options": {
-                        "main": "src/test.ts",
-                        "polyfills": "src/polyfills.ts",
-                        "tsConfig": "src/tsconfig.spec.json",
-                        "karmaConfig": "src/karma.conf.js",
+                        "tsConfig": "tsconfig.spec.json",
+                        "inlineStyleLanguage": "scss",
+                        "assets": [
+                            "src/favicon.ico",
+                            "src/assets",
+                            "src/robots.txt",
+                            "src/sitemap.xml"
+                        ],
+                        "polyfills": ["zone.js", "zone.js/testing"],
                         "styles": ["src/styles.scss"],
-                        "scripts": [],
-                        "assets": ["src/favicon.ico", "src/assets"]
+                        "scripts": []
                     }
                 },
                 "lint": {
@@ -134,15 +123,6 @@
                         }
                     },
                     "defaultConfiguration": "production"
-                },
-                "test": {
-                    "builder": "@angular-devkit/build-angular:karma",
-                    "options": {
-                        "main": "projects/ngx-loader-indicator-lib/src/test.ts",
-                        "polyfills": "src/polyfills.ts",
-                        "tsConfig": "projects/ngx-loader-indicator-lib/tsconfig.spec.json",
-                        "karmaConfig": "projects/ngx-loader-indicator-lib/karma.conf.js"
-                    }
                 }
             }
         }