bump: .net 8

JoshKeegan · Nov 16, 2023 · 09859ec · 09859ec
1 parent 6197679
commit 09859ec
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/cicd.yaml b/.github/workflows/cicd.yaml
@@ -8,7 +8,7 @@ jobs:
   ci_build:
     name: CI Build
     runs-on: ubuntu-latest
-    container: joshkeegan/dotnet-mixed-build:6.1
+    container: joshkeegan/dotnet-mixed-build:7.0
     steps:
       - name: Checkout
         uses: actions/checkout@v3

diff --git a/test/UnitTests.SingleThreaded/UnitTests.SingleThreaded.csproj b/test/UnitTests.SingleThreaded/UnitTests.SingleThreaded.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net48</TargetFrameworks>
+    <TargetFrameworks>net8.0;net48</TargetFrameworks>
 
     <IsPackable>false</IsPackable>
   </PropertyGroup>

diff --git a/test/UnitTests/Exceptions/SkipTestExceptionTests.cs b/test/UnitTests/Exceptions/SkipTestExceptionTests.cs
@@ -18,11 +18,11 @@ public void Serialisation_RoundTrip_RetainsData()
 
             // Act
             SkipTestException actual;
+#pragma warning disable SYSLIB0011 // Type or member is obsolete
+#pragma warning disable 618
             BinaryFormatter formatter = new BinaryFormatter();
             using (MemoryStream s = new MemoryStream())
             {
-#pragma warning disable SYSLIB0011 // Type or member is obsolete
-#pragma warning disable 618
                 formatter.Serialize(s, expected);
                 s.Position = 0;
                 actual = (SkipTestException) formatter.Deserialize(s);

diff --git a/test/UnitTests/UnitTests.csproj b/test/UnitTests/UnitTests.csproj
@@ -1,10 +1,15 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net48</TargetFrameworks>
+    <TargetFrameworks>net8.0;net48</TargetFrameworks>
 
     <IsTestProject>true</IsTestProject>
     <IsPackable>false</IsPackable>
+
+    <!-- Required to enable BinaryFormatter so we can test [Serializable] exceptions. 
+         I don't know if anyone uses them, but it would be a breaking change to stop exceptions being serialisable, 
+         and the BinaryFormatter is only required in this test project. -->  
+    <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization>
   </PropertyGroup>
 
   <ItemGroup>