Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove defaultScope from customScope #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptunay
Copy link

@ptunay ptunay commented Jun 15, 2022

Issue: #25

For cases when we don't need the 'https://www.googleapis.com/auth/drive.readonly' scope and supply our own customScope

For cases when we don't need the 'https://www.googleapis.com/auth/drive.readonly' scope and supply our own customScope
@mkosik
Copy link

mkosik commented Feb 1, 2023

This is very important for prod, since the current default scope is "restricted" & requires a very difficult verification process.
See: Google OAuth API verification FAQs
Without this change, it makes this library as is practically unusable in prod for many.

Even Google recommends just "https://www.googleapis.com/auth/drive.file" scope, which is specifically not restricted.
See: Drive Picker API Docs

@mkosik
Copy link

mkosik commented Feb 1, 2023

Would also recommend to update defaultScopes to "https://www.googleapis.com/auth/drive.file", as well as customScopes mentioned in demo/src/App.tsx and /README.md as recommended by aforementioned Drive Picker API Docs, so the new users of the lib won't be confused.

@filippofilip95
Copy link

During the verification process from Google they recommended us to use https://www.googleapis.com/auth/drive.file only, instead of the defaultScope which is used in the lib.

We'd appreciate the merging of this PR as well.

@Ayan-Bandyopadhyay
Copy link

Also ran into this issue because I needed to use the drive.file scope in my app, so merging in this PR would be nice. In the meantime I've made a fork with the fix for anyone that needs it: https://github.com/psychic-api/React-google-drive-picker

@fyelci
Copy link

fyelci commented Oct 12, 2023

I forked this repo and published as @fyelci/react-google-drive-picker. This should solve the issue. I also upgraded dependencies.

https://www.npmjs.com/package/@fyelci/react-google-drive-picker

@ianpandis
Copy link

During the verification process from Google they recommended us to use https://www.googleapis.com/auth/drive.file only, instead of the defaultScope which is used in the lib.

We'd appreciate the merging of this PR as well.

Having this same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants