CSS fix for Jenkins 2.346+ #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(css): Fix css id for the jenkins page. Keeping old id for backward compatibility. See: Issue jenkinsci/simple-theme-plugin#83 on Jenkins plugins Signed-off-by: offa <[email protected]>
|
Hey! wanted to check if you plan to merge this change, if yes, then when do you plan to do so. Thanks! |
|
Hi, may I know when this change will be merge? |
|
We have to wait for @Jorg3Lucas |
|
Heads up, I took the modern-pink and modern-blue for a test drive and text color in the console output and some settings are difficult to view. The font color of the text in the console output is now dark grey with v2.346.1 on top of light grey. The background color being applied to the console output is still black with the themes. Edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken theming on Jenkins 2.346 LTS.
Applies the patch created by @cossons: afonsof/jenkins-material-theme#199
closes #67