-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sharp 0.33 #664
Bump sharp 0.33 #664
Conversation
🦋 Changeset detectedLatest commit: ea6561a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks @birkskyum. I kicked off the CI and it looks like you'll have to update a few test assertions as part of this PR |
Hmm, it's more than test assertions it would seem. There is this change in the heif options that imagetools need to adapt to:
Also the tint weight seem to have changed:. |
I've added this return image.toFormat(format, {
compression: format == 'heif' ? 'av1' : undefined,
quality: getQuality(config, image),
lossless: getLossless(config, image) as boolean,
progressive: getProgressive(config, image) as boolean
}) |
Okay, I've tried to update the tests |
Getting close. Rolled back a change, so the tests in the vite package are unchanged. Good chance it'll pass now on CI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 93.60% 93.60%
=======================================
Files 32 32
Lines 1188 1189 +1
Branches 188 189 +1
=======================================
+ Hits 1112 1113 +1
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sharp 0.33 solves a lot of issues around installation due to the postinstall script, and it brings it's own types which the Renovate PR doesn't get right.
Fixing this in imagetools, will i.e. fix a lot downstream issues of installing. Here is i.e. an example of Qwik with Deno etc.
Support Qwik City (dev server) denoland/deno#20612
Quick Checklist
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
PR?)
Other information: