fix!: rename screw_pitch to screw_lead #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have since learned that the movement caused by a full rotation of the lead screw is called the lead. A 1 start 2mm pitch lead screw has a lead of 2mm. But the SV06 has a 2mm pitch 2 start, with a lead of 4mm. This caused wrong estimated turns with my example configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have since learned that the movement caused by a full rotation of the lead screw is called the lead.
A 1 start 2mm pitch lead screw has a lead of 2mm.
But the SV06 has a 2mm pitch 2 start, with a lead of 4mm.
This caused wrong estimated turns with my example configuration.