Use newer Qt version (5.15.10) on macOS

[Jojo-Schmitz]

Resolves: musescore#16533
Resolves: musescore#17740

Backport of musescore#17772, needed as this branch also used Qt 5.15 and not 5.9 like 3.6.2 and earlier

Needs QWebEngine though, that so far isn't part of https://s3.amazonaws.com/utils.musescore.org/Qt5159_mac.zip

[Jojo-Schmitz]

Seems too much effort (need to build Qt from scratch) for too little effect

[Jojo-Schmitz]

See also #232, but also #93

[Jojo-Schmitz]

Maybe I found a way to get Qt build on GitHub... 'stolen' from https://github.com/cbjeukendrup/musescore_build_qt

[Jojo-Schmitz]

Pity, still things from Qt WebEngine seem to be missing

@cbjeukendrup if you find the time, mind to check where/why this might have gone wrong?

[cbjeukendrup]

I never created builds with WebEngine myself. That was done by Antonio Lotti, see musescore#17997 (comment). You won't be able to download those builds anymore by now, because GitHub saves them only 90 days; but you can create new ones by forking his repo and then running the GH Action.

[Jojo-Schmitz]

That's what I did (actually I forked your's), but still running into problems.

@AntonioBL: any idea?

[cbjeukendrup]

You forked my repo, rather than @AntonioBL's, and again, my repo doesn't have anything with Qt 5 WebEngine.

[Jojo-Schmitz]

Got it. Your repo has actions that look like doing something with WebEngine though...

[cbjeukendrup]

Oh, you're right. Apparently my attempts did have results. The problem seems something different: https://github.com/Jojo-Schmitz/musescore_build_qt/actions/runs/10850041193/job/30115719091#step:7:10

So Python 2 is needed, which is so old that it's no longer shipped with macOS since version 12.3. Looks like the best way to install it is using pyenv: https://stackoverflow.com/a/67274521

[Jojo-Schmitz]

Thanks, will try that

[Jojo-Schmitz]

Hmm, Jojo-Schmitz/musescore_build_qt@95bb9ce doesn't do the trick though

[cbjeukendrup]

Based on that SO answer, maybe this works?

        brew install pyenv
        pyenv install 2.7.18
        pyenv global 2.7.18
        echo "$(pyenv root)/shims" >> $GITHUB_PATH

[Jojo-Schmitz]

Hmmm, ok, I'll try

[Jojo-Schmitz]

Got much further with that, but then fails compilation.

[cbjeukendrup]

You could look at https://github.com/Homebrew/homebrew-core/blob/26bd22e37e641c3a1571fac5913a7774aca24c64/Formula/q/[email protected]. This is HomeBrew's spec for how to install and build the latest Qt 5. You cannot just take Qt from HomeBrew, as HomeBrew binaries aren't really suitable for redistribution (they contain some hardcoded paths etc). But you can take inspiration from which patches it applies.
Unless you happen to know Ruby, the syntax is weird, but you can probably figure out what it approximately does. See my musescore_build_qt repo for how patches could be applied.

[Jojo-Schmitz]

Build for Qt 5.15.10 fails with:

2024-09-17T06:50:34.7761260Z In file included from gen/third_party/blink/renderer/core/editing/editing_jumbo_9.cc:7:
2024-09-17T06:50:34.7764870Z ./../../../../../qt-everywhere-src-5.15.10/qtwebengine/src/3rdparty/chromium/third_party/blink/renderer/core/editing/finder/text_finder.cc:632:10: error: ambiguous conversion for functional-style cast from 'blink::FloatRect' to 'gfx::RectF'
2024-09-17T06:50:34.7767880Z   return gfx::RectF(FindInPageRectFromRange(EphemeralRange(ActiveMatch())));
2024-09-17T06:50:34.7768940Z          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024-09-17T06:50:34.7771220Z ../../../../../qt-everywhere-src-5.15.10/qtwebengine/src/3rdparty/chromium/ui/gfx/geometry/rect_f.h:26:23: note: candidate constructor (the implicit move constructor)
2024-09-17T06:50:34.7773160Z class GEOMETRY_EXPORT RectF {
2024-09-17T06:50:34.7773700Z                       ^
2024-09-17T06:50:34.7775610Z ../../../../../qt-everywhere-src-5.15.10/qtwebengine/src/3rdparty/chromium/ui/gfx/geometry/rect_f.h:26:23: note: candidate constructor (the implicit copy constructor)
2024-09-17T06:50:34.7778620Z ../../../../../qt-everywhere-src-5.15.10/qtwebengine/src/3rdparty/chromium/ui/gfx/geometry/rect_f.h:43:12: note: candidate constructor
2024-09-17T06:50:34.7781000Z   explicit RectF(const CGRect& r);
2024-09-17T06:50:34.7781800Z            ^

Build for Qt 5.15.15 fails with

2024-09-17T17:44:45.5581150Z In file included from gen/base/base_jumbo_19.cc:16:
2024-09-17T17:44:45.5609170Z ./../../../../../qt-everywhere-src-5.15.15/qtwebengine/src/3rdparty/chromium/base/strings/utf_string_conversions.cc:21:16: error: duplicate explicit instantiation of 'basic_string<unsigned short, base::string16_internals::string16_char_traits>'
2024-09-17T17:44:45.5613800Z template class basic_string<base::char16, base::string16_internals::string16_char_traits>;
2024-09-17T17:44:45.5614820Z                ^
2024-09-17T17:44:45.5616800Z ../../../../../qt-everywhere-src-5.15.15/qtwebengine/src/3rdparty/chromium/base/strings/string16.h:209:10: note: previous explicit instantiation is here
2024-09-17T17:44:45.5618470Z     std::basic_string<base::char16,
2024-09-17T17:44:45.5619310Z          ^
2024-09-17T17:44:45.5619680Z 1 error generated.

[cbjeukendrup]

I can't really help with that specifically, you'll really have to look at the patches that HomeBrew applies.