Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various states of Motions #4191

Open
wants to merge 29 commits into
base: feature/4157-cancel-modal
Choose a base branch
from

Conversation

agnieszkajarosikloj
Copy link

Description

This PR adds section with the history of created Motions. Each motion in the list is a link (hardcoded now) and a tag with the motion status (pending, failed or passed, also hardcoded).

New stuff

  • Linked Motions section.

Design

Screenshot 2023-02-09 at 12 01 38

Resolves #4188

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@agnieszkajarosikloj agnieszkajarosikloj changed the title Feature/4188 linked motions Add various states of Motions Feb 9, 2023
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agnieszkajarosikloj, just one comment regarding the timeout.

@@ -55,7 +51,31 @@ const IncorporationPage = () => {
}, []);

const handlePay = useCallback(() => {
setActiveStageId(StagesEnum.Processing);
setMotions((prevState) => [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor this without the timeout, it is really only useful for reviewing and won't be needed for the interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants