Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incorporation modal with slides #4163

Conversation

agnieszkajarosikloj
Copy link

@agnieszkajarosikloj agnieszkajarosikloj commented Jan 26, 2023

Description

This PR adds Modal with Slides, to learn about DAO incorporation. Modal consists of 3 tabs and slides. User can switch between slides by clicking on the tab or on the button.

To test click on the New Action button and choose DAO Incorporation option.

New stuff

  • Modal with slides about DAO incorporation.

Changes 🏗

  • Added widthAuto prop to the Dialog core component. With this flag set to true, the dialog can be wider than 500 pixels.

Screenshot 2023-01-26 at 23 04 28

Figma Link - Slide 1
Figma Link - Slide 2
Figma Link - Slide 3

Resolves #4154

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@agnieszkajarosikloj agnieszkajarosikloj changed the base branch from feature/DAO-incorporation-option to feature/4139-DAO-incorporation-option January 26, 2023 22:16
@agnieszkajarosikloj agnieszkajarosikloj force-pushed the feature/4139-DAO-incorporation-option branch from 3b60cdf to 164ee32 Compare January 31, 2023 22:30
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agnieszkajarosikloj, this has the same issue as #4141 regarding Incorporating being in the wrong location of the modal.

},
step5: {
id: 'dashboard.DAOIncorporationDialog.TabPanels.HowPanel.step5',
defaultMessage: `Korporatio will process the application and finalise the incorporate. The DAO will then be able to start benefitting for a legal DAO wrapper.<div> Step time: 15 - 20 business days </div>`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a type here, please change to: "Korporatio will process the application and finalize the incorporation. The DAO and contributors will then start benefiting from the legal DAO wrapper.

Step time: 15 - 20 business days"

},
description: {
id: 'dashboard.DAOIncorporationDialog.TabPanels.WhyPanel.description',
defaultMessage: `Setup a legal wrapper for you DAO to extend it’s functionality and help protect contributors. Incorporation is done in Panama through a partner of Colony, Korporatio. Who is specifically focused on helping to support smart companies built and run on-chain.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to: "Setup a legal wrapper for you DAO to extend it’s functionality and help protect contributors. Incorporation is done in Panama through a service provided by Korporatio. Who is specifically focused on helping to support smart companies built and run on-chain."

@agnieszkajarosikloj
Copy link
Author

@arrenv I added changes. Can you have a look?

Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo on my end, but I have approved.

},
description: {
id: 'dashboard.DAOIncorporationDialog.TabPanels.WhyPanel.description',
defaultMessage: `Setup a legal wrapper for you DAO to extend it's functionality and help protect contributors. Incorporation is done in Panama through a service provided by Korporatio. Who is specifically focused on helping to support smart companies built and run on-chain.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I have a typo in my replacement, it should be: "Setup a legal wrapper for your DAO to extend it's functionality and help protect contributors. Incorporation is done in Panama through a service provided by Korporatio. Who is specifically focused on helping to support smart companies built and run on-chain."

@agnieszkajarosikloj agnieszkajarosikloj merged commit 4f09098 into feature/4139-DAO-incorporation-option Feb 23, 2023
@agnieszkajarosikloj agnieszkajarosikloj deleted the feature/4154-incorporation-modal branch February 23, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants