-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add incorporation modal with slides #4163
Add incorporation modal with slides #4163
Conversation
|
3b60cdf
to
164ee32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agnieszkajarosikloj, this has the same issue as #4141 regarding Incorporating being in the wrong location of the modal.
}, | ||
step5: { | ||
id: 'dashboard.DAOIncorporationDialog.TabPanels.HowPanel.step5', | ||
defaultMessage: `Korporatio will process the application and finalise the incorporate. The DAO will then be able to start benefitting for a legal DAO wrapper.<div> Step time: 15 - 20 business days </div>`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a type here, please change to: "Korporatio will process the application and finalize the incorporation. The DAO and contributors will then start benefiting from the legal DAO wrapper.
}, | ||
description: { | ||
id: 'dashboard.DAOIncorporationDialog.TabPanels.WhyPanel.description', | ||
defaultMessage: `Setup a legal wrapper for you DAO to extend it’s functionality and help protect contributors. Incorporation is done in Panama through a partner of Colony, Korporatio. Who is specifically focused on helping to support smart companies built and run on-chain.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to: "Setup a legal wrapper for you DAO to extend it’s functionality and help protect contributors. Incorporation is done in Panama through a service provided by Korporatio. Who is specifically focused on helping to support smart companies built and run on-chain."
80e8fba
to
c2d9ce8
Compare
@arrenv I added changes. Can you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one typo on my end, but I have approved.
}, | ||
description: { | ||
id: 'dashboard.DAOIncorporationDialog.TabPanels.WhyPanel.description', | ||
defaultMessage: `Setup a legal wrapper for you DAO to extend it's functionality and help protect contributors. Incorporation is done in Panama through a service provided by Korporatio. Who is specifically focused on helping to support smart companies built and run on-chain.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, I have a typo in my replacement, it should be: "Setup a legal wrapper for your DAO to extend it's functionality and help protect contributors. Incorporation is done in Panama through a service provided by Korporatio. Who is specifically focused on helping to support smart companies built and run on-chain."
Description
This PR adds Modal with Slides, to learn about DAO incorporation. Modal consists of 3 tabs and slides. User can switch between slides by clicking on the tab or on the button.
To test click on the New Action button and choose DAO Incorporation option.
New stuff ✨
Changes 🏗
Figma Link - Slide 1
Figma Link - Slide 2
Figma Link - Slide 3
Resolves #4154