Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Popen handle if requested #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kunaltyagi
Copy link
Contributor

Allows easy interruption, potentially answers #20

Allows easy interruption, potentially answers Johannes11833#20
@kunaltyagi
Copy link
Contributor Author

@Johannes11833 What's the black version and python target syntax? Latest black on python 3.11 doesn't show any changes

@Johannes11833
Copy link
Owner

I don't understand, how your changes would allow for easy interruption. Even with the popen handle being returned in the copy function (which it is not atm) for example, the rclone copy operation is first fully executed before we receive the handle.
So an interruption would still not be possible with you changes the way I see it.
Am i missing something?

@Johannes11833
Copy link
Owner

@Johannes11833 What's the black version and python target syntax? Latest black on python 3.11 doesn't show any changes

I am using the vscode extension of black with apprently black=23.10.1

@kunaltyagi
Copy link
Contributor Author

kunaltyagi commented Nov 12, 2023

The flag allows for a return before the wait. I ofc forgot to return the handle everywhere 🤦🏾‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants